Fire onInit callback if instance is already available #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: 79f0a00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis ReportAffected Products
|
…dk into mrschmidt/fixauth
Feiyang1
approved these changes
Jun 7, 2021
Feiyang1
suggested changes
Jun 7, 2021
Feiyang1
reviewed
Jun 8, 2021
packages/component/src/provider.ts
Outdated
| this.onInitCallbacks.add(callback); | ||
|
|
||
| const instance = this.getImmediate({ identifier, optional: true }); |
There was a problem hiding this comment.
Can you please add a comment that OnInit() is only intended to be used for EXPLICIT components, so getImmediate() will never initialize a new instance?
Feiyang1
reviewed
Jun 9, 2021
Co-authored-by: Feiyang <[email protected]>
Co-authored-by: Feiyang <[email protected]>
Co-authored-by: Feiyang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Firestore's initialization to detect Auth if Auth is available during client startup. Right now, we only detect once the
setTimeoutcall fires.Fixes #3218
Fixes #4953
Fixes #4932